Qt6 (QGIS 4) compatibility #1036

signedav · 2025-06-16T08:52:57Z

Qt6 upgrade performed by pyqgis4-checker:

docker run -it --rm -v /home/dave/dev/opengisch/QgisModelBaker:/home/pyqgisdev/ registry.gitlab.com/oslandia/qgis/pyqgis-4-checker/pyqgis-qt-checker:latest pyqt5_to_pyqt6.py --logfile /home/pyqgisdev/pyqt6_checker.log .

See https://github.com/qgis/QGIS/wiki/Plugin-migration-to-be-compatible-with-Qt5-and-Qt6 and https://github.com/qgis/pyqgis4-checker

Requires opengisch/QgisModelBakerLibrary#144

For big parts this resolves #985

Manual checks

Removed Modules in Qt 6.0
Changes to Qt Modules in Qt 6
Qt Namespace, all enums in Qt
overview of the differences between PyQt6 and PyQt5 (https://www.riverbankcomputing.com/static/Docs/PyQt6/pyqt5_differences.html)

Test manually

Docker approach

docker build --pull --rm -f qgis-qt6-unstable.dockerfile     --progress=plain     --build-arg QGIS_GIT_VERSION=master     -t qgis-qt6-unstable:local .

and:

xhost +local:docker

and:

docker run -it --rm   -e DISPLAY=$DISPLAY   -e LC_ALL=C.utf8   -e LANG=C.utf8   -v /tmp/.X11-unix:/tmp/.X11-unix     -v /home/dave/.local/share/QGIS/QGIS3/profiles/modelbaker:/home/quser/.local/share/QGIS/QGIS3/profiles/default qgis-qt6-unstable:local   qgis

with:

-v /home/dave/.local/share/QGIS/QGIS3/profiles/modelbaker:/home/quser/.local/share/QGIS/QGIS3/profiles/default

but does not work

Flatpack approach

Got flatpack from http://duif.net/qgis-qt6.flatpak

And this works...

Results

Deprecated FollowREdirectsattribute mode -> could be skipped when Qt6 (but not with Qt5)
setFilterRegularExpression replaces setFilterRegExp
~~The gui is f... up. Sizes are not correct. (Test here on the other computer)~~ was only the case with my weird laptop that as issues anyway
Could not test Java interaction with flat pack (it says no java is installed)
I tried to install Java flatpak and pass this --env=JAVA_HOME=/var/lib/flatpak/runtime/org.freedesktop.Sdk.Extension.openjdk but made no difference
Could not gather models from repo:
And it says Warning: Qt: Session management error: Could not open network socket
I tried to pass this to the flatpak --device=all --filesystem=host --share=network but made no difference
Do we need to support Qt < 5.12? (if so,then we need setFilterRegExp)

signedav · 2025-06-30T12:14:18Z

@gacarrillor Do you think we could ignore that java and network is not working with the flatpak?

Btw. I receive this message on starting it Warning: Qt: Session management error: Could not open network socket Any idea?

gacarrillor · 2025-07-01T14:47:20Z

QgisModelBaker/qgismodelbaker.py

+            Qt.DockWidgetArea(
+                settings.value(
+                    "QgisModelBaker/validate_dock/area",
+                    2,


Something like Qt.DockWidgetArea.RightDockWidgetArea instead of 2 to be more explicit?

It has a problem with that. Tells me it's not an integer.

Does this work on your flatpak instance:

QSettings().value("QgisModelBaker/validate_dock/area", Qt.DockWidgetArea.RightDockWidgetArea, type=int)

Hm... Have to check that.

Does this work on your flatpak instance:

QSettings().value("QgisModelBaker/validate_dock/area", Qt.DockWidgetArea.RightDockWidgetArea, type=int)

TypeError: QgisInterface.addDockWidget(): argument 1 has unexpected type 'int'

And when I do this:

QSettings().value("QgisModelBaker/validate_dock/area", Qt.DockWidgetArea.RightDockWidgetArea, type=Qt.DockWidgetArea),

TypeError: unable to convert a QVariant of type 10 to a QMetaType of type 65858

That's why I decided to read it as integer and cast then...

In Qt6 we could at least take Qt.DockWidgetArea.RightDockWidgetArea.value instead of 2 but this would not work with Qt5... 🤷

@signedav, I think we forgot this one?

No, but I forgot to submit my review comments. See above...

QgisModelBaker/utils/gui_utils.py

QgisModelBaker/gui/workflow_wizard/workflow_wizard.py

gacarrillor · 2025-07-01T15:13:20Z

@gacarrillor Do you think we could ignore that java and network is not working with the flatpak?

Btw. I receive this message on starting it Warning: Qt: Session management error: Could not open network socket Any idea?

@signedav, if the flatpak build is not letting us fully test MB, I guess we could try these changes on a Windows build with support for Qt6. Do you have access to a Windows machine? If not, I could give it a try by the end of this week.

signedav · 2025-07-01T18:49:50Z

Do you have access to a Windows machine? If not, I could give it a try by the end of this week.

This would be great.

gacarrillor · 2025-07-01T21:23:00Z

Do you have access to a Windows machine? If not, I could give it a try by the end of this week.

This would be great.

Before that, I'd appreciate if you can upload a zipped dev version of the plugin somewhere.
Also, if you'd like that I test some particular module or case, just let me know.

signedav · 2025-07-02T06:55:43Z

Off today. I'll do it tomorrow.

docker run -it --rm -v /home/dave/dev/opengisch/QgisModelBaker:/home/pyqgisdev/ registry.gitlab.com/oslandia/qgis/pyqgis-4-checker/pyqgis-qt-checker:latest pyqt5_to_pyqt6.py --logfile /home/pyqgisdev/pyqt6_checker.log . For big parts this resolves #985

…dockWidget

github-actions · 2025-07-03T07:55:22Z

🧁 Ta-daaa, find a test ZIP of bd0a3fc here.

signedav · 2025-07-03T09:20:04Z

@gacarrillor Can you test with the zip here #1036 (comment)

gacarrillor · 2025-07-04T17:59:06Z

Manual Tests for Qt6 on Windows:

WIZARD

The list of models is not displayed when entering any search string (e.g. nutz).
- This message is shown in the QGIS Log Message Viewer (modelbaker tab):
  2025-07-04T16:42:46 WARNING There was an error connecting to the database. Check connection parameters. Error details: connection to server at "localhost" (::1), port 5432 failed: fe_sendauth: no password supplied

Project Generation

It works!

ili2db

Downloading ili2db I got this error (actually, even on Ubuntu it's often the case that I have to install libs manually, because of strange errors: a timeout, if I remember correctly):

 > ---------- Schema Import Configuration
 > ---------- Schema Import Sessions
Downloading ili2pg version 5.3.1…
.
.
.
.
Could not download ili2pg

  Error: Unknown error

File "C:\Users\user\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\QgisModelBaker\libs\modelbaker\iliwrapper\bin\ili2pg-5.3.1\ili2pg-5.3.1.jar" not found. Please download and extract <a href="https://downloads.interlis.ch/ili2pg/ili2pg-5.3.1.zip">ili2pg</a>

SCHEMA IMPORT

On GPKG, all OK, including baskets and OIDs.
On PostGIS:
- I've stumbled upon this bug, which also occurs in Qt5.
- With a proper model and connection, and having ilid2db libs installed, it worked fine.

DATA IMPORT

It works!

DATA EXPORT

It works!

VALIDATOR

It works!

BASKETS/DATASETS

Worked fine, but got several messages like these in the Log Message Viewer (Messages tab). Note that I used a QGIS dev build, so debug was enabled:

    2025-07-04T16:39:50     CRITICAL    Qt : beginResetModel called on BasketSourceModel(0x284f552f970) without calling endResetModel first
    2025-07-04T16:39:50     CRITICAL    Qt : beginResetModel called on QSortFilterProxyModel(0x284f1554f20) without calling endResetModel first
    2025-07-04T16:39:50     CRITICAL    Qt : endResetModel called on BasketSourceModel(0x284f552f970) without calling beginResetModel first
    2025-07-04T16:39:50     CRITICAL    Qt : endResetModel called on QSortFilterProxyModel(0x284f1554f20) without calling beginResetModel first

When changing the Dataset of a specific basket in the Basket Manager (Layers were in Edit model), we've got an error message (I guess it's expected, but then we could disable the edit buttons in Dataset and Basket Managers if layers are on edit mode):

I attempted the same edit operation with layers in non-edit mode, and then it worked!

QUICK VISUALIZER

It works!

signedav · 2025-07-04T19:14:00Z

Cool, thanks for testing.

Am I right that the network issue (listing of models and ili2db download) happens on Qt6 only and the others as well on the current QGIS release?

If so we should solve the Qt6 in a first step and check the others independently.

gacarrillor · 2025-07-04T21:01:18Z

Am I right that the network issue (listing of models and ili2db download) happens on Qt6 only and the others as well on the current QGIS release?

I've experienced the ili2db download issues on Qt5. Actually, I think I'm used to install those libs manually.
The listing of models is a Qt6 thing, yes.

signedav · 2025-07-05T20:47:08Z

Okay, since the listing of models is reproducible by flatpak I'll check this out.

Would you mind to create separate issues for the other problems? Except the thing with ili2db download. I think this is a problem with the server. And we cannot solve it since we are not allowed to ship java code in plugins AFAIK.

gacarrillor · 2025-07-07T17:25:49Z

Would you mind to create separate issues for the other problems? Except the thing with ili2db download. I think this is a problem with the server. And we cannot solve it since we are not allowed to ship java code in plugins AFAIK.

Done at #1041 and #1042. I was unable to reproduce them using a Qt5-build on GNU/Linux. Therefore, I marked them as Qt6-only.

signedav · 2025-07-08T07:44:48Z

This message is shown in the QGIS Log Message Viewer (modelbaker tab): 2025-07-04T16:42:46 WARNING There was an error connecting to the database. Check connection parameters. Error details: connection to server at "localhost" (::1), port 5432 failed: fe_sendauth: no password supplied

Minor thing. See #1043

signedav · 2025-07-08T10:46:33Z

See opengisch/QgisModelBakerLibrary#146

signedav · 2025-07-08T14:26:57Z

Okay, when I merge it and we publish an experimental soonish?

signedav requested a review from gacarrillor June 30, 2025 12:13

gacarrillor approved these changes Jul 1, 2025

View reviewed changes

signedav force-pushed the qt6 branch from 7382c6f to 90ed2ab Compare July 3, 2025 07:34

signedav added 9 commits July 3, 2025 09:47

maximum version 4.99

ac1bac2

support qt6 flag in metadata

afcef7d

replace some function that are deprecated in QSortFilterProxyModel

36f85c5

ensure backwards compatibility qt<5.12 and fix error on setting read …

4d8f053

…dockWidget

fix typos and copy paste mistakes

bf5f283

silly test

e1562c4

novalidation

ce4b97a

qt6 checker again

6999e6b

signedav force-pushed the qt6 branch from e0b785a to 6999e6b Compare July 3, 2025 07:49

ci

310afc6

signedav force-pushed the qt6 branch from 88b911d to 310afc6 Compare July 3, 2025 09:20

This was referenced Jul 7, 2025

[Qt6] Using baskets and datasets logs critical messages #1042

Open

[Qt6] When layers are in edit mode, Dataset and Basket Managers should be read only #1041

Open

bump mb 2.0.1

bd0a3fc

signedav merged commit 1d8b17b into master Jul 10, 2025
8 checks passed

signedav deleted the qt6 branch July 10, 2025 13:31

Uh oh!

Qt6 (QGIS 4) compatibility #1036

Qt6 (QGIS 4) compatibility #1036

Uh oh!

Conversation

signedav commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual checks

Test manually

Docker approach

Flatpack approach

Results

Uh oh!

signedav commented Jun 30, 2025

Uh oh!

gacarrillor Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

signedav Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

gacarrillor Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

signedav Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

signedav Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

gacarrillor Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

signedav Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gacarrillor commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

signedav commented Jul 1, 2025

Uh oh!

gacarrillor commented Jul 1, 2025

Uh oh!

signedav commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

signedav commented Jul 3, 2025

Uh oh!

gacarrillor commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

signedav commented Jul 4, 2025

Uh oh!

gacarrillor commented Jul 4, 2025

Uh oh!

signedav commented Jul 5, 2025

Uh oh!

gacarrillor commented Jul 7, 2025

Uh oh!

signedav commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

signedav commented Jul 8, 2025

Uh oh!

signedav commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

signedav commented Jun 16, 2025 •

edited

Loading

gacarrillor commented Jul 1, 2025 •

edited

Loading

github-actions bot commented Jul 3, 2025 •

edited

Loading

gacarrillor commented Jul 4, 2025 •

edited

Loading

signedav commented Jul 8, 2025 •

edited

Loading